| From | David Howells <> | Subject | Re: [PATCH 05/10] rwsem: wake queued readers when writer blocks on active read lock | Date | Wed, 19 May 2010 13:44:57 +0100 |
| |
Michel Lespinasse <walken@google.com> wrote:
> + * Alternatively, if we're called from a failed down_write(), there > + * were already threads queued before us, and there are no active > + * writers, the lock must be read owned; so we try to wake any read > + * locks that were queued ahead of us. */
The comma you've added after 'us' is wrong. That suggests that the implicit 'then' comes there. I take it you're a proponent of the Oxford/Harvard/serial comma?
Apart from that miscellaneous grammatical difference, the patch is fine:-)
David
|