lkml.org 
[lkml]   [2010]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH -V8 2/9] vfs: Add name to file handle conversion support
Date
On Tue, 18 May 2010 15:18:28 +0900, "J. R. Okajima" <hooanon05@yahoo.co.jp> wrote:
>
> "Aneesh Kumar K. V":
> > The file_handle I mentioned above is the file handle returned by
> > sys_name_to_handle_at syscall. NFS kernel server won't be using the
> > interface.
>
> Thanx clarifying.
> I think I should read the notes in the first description (0/9) before
> posting.
> It says UUID is just for userspace.
>
> Reading all 9 patches, I noticed handle_to_path() calls
> exportfs_decode_fh() inconditionally.
> Since exportfs_decode_fh() calls s_export_op->fh_to_dentry()
> inconditionally too, handle_to_path() will crash when the target FS
> doesn't support NFS-exporting, won't it?
>

I guess we should fix exprtfs_decode_fh to return -ESTALE if
fh_to_dentry is NULL

-aneesh


\
 
 \ /
  Last update: 2010-05-18 09:01    [W:0.049 / U:7.568 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site