lkml.org 
[lkml]   [2010]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 5/7] arch/x86: Add array variants for setting memory to wc caching.
From
On Tue, May 18, 2010 at 9:43 AM, H. Peter Anvin <h.peter.anvin@intel.com> wrote:
> On 05/18/2010 02:34 AM, Dave Airlie wrote:
>> On Thu, Apr 1, 2010 at 10:45 PM, Pauli Nieminen <suokkos@gmail.com> wrote:
>>> Setting single memory pages at a time to wc takes a lot time in cache flush. To
>>> reduce number of cache flush set_pages_array_wc and set_memory_array_wc can be
>>> used to set multiple pages to WC with single cache flush.
>>>
>>> This improves allocation performance for wc cached pages in drm/ttm.
>>>
>>
>> I've got this in drm-next for quite a while and almost forgot about
>> it, I'm meant to be on holidays and I'd really like to just have Linus
>> pull my tree,
>>
>> I had only one issue with this as we had some problems with doing it
>> before but it looks like they've since been fixed in the x86 pat code
>> a kernel or two ago so this patch should be fine now.
>>
>> its been well tested in drm-next on AGP machines by the author,
>>
>> any objections to this?
>>
>> Dave.
>
> Acked-by: H. Peter Anvin <hpa@zytor.com>
>
> Go ahead and push it; the patch is straightforward, and the author
> (Venki) is reliable.
>
>        -hpa
>
> P.S. Please Cc: all the x86 maintainers, not just Ingo.
>

Patch actually from Pauli.
Looks good.

Acked-by: Venkatesh Pallipadi <venki@google.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-05-18 22:57    [W:0.029 / U:5.968 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site