Messages in this thread | | | Date | Tue, 18 May 2010 13:29:36 -0700 (PDT) | From | Dan Magenheimer <> | Subject | RE: [PATCH] x86: Export tsc related information in sysfs |
| |
> From: H. Peter Anvin [mailto:hpa@zytor.com] > Subject: Re: [PATCH] x86: Export tsc related information in sysfs > > On 05/18/2010 12:16 PM, Dan Magenheimer wrote: > > And the reason I expect tglx/arjan/andi/mingo to disagree is because > > their position is that there is NO safe use for rdtsc in userspace > EVER! > > Whereas your position stated earlier: > > > >> There are restricted uses of the TSC in userspace which are still > >> useful > >> (mainly involving performance analysis and/or CPU-locked processes). > > > > says there are. > > > > While the engineer in me agrees with tglx/arjan/andi/mingo, the > > realist in me agrees with you. > > I should have added "that are not related to wall time" to the > statement above.
Yes... that still puts your opinion at odds with tglx/etc. All of the cases I am concerned with ARE performance analysis uses, not wall time uses.
> Furthermore, vsyscalls are user space from a CPU perspective.
Yes, understood, a minor semantic issue. From a kernel perspective vsyscalls are kernelspace, so IIUC this is OK with tglx/etc.
Since vsyscall shouldn't be using rdtsc when the kernel doesn't trust TSC, it doesn't matter if CR4.TSD is enabled when the kernel doesn't trust TSC.
I'm still not sure if you are in favor of optionally emulating PL3 rdtsc instructions or not? I thought my proposal was just filling out some details of your proposal and suggesting a default.
| |