[lkml]   [2010]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RFC] Tracer Ring Buffer splice() vs page cache [was: Re: Perf and ftrace [was Re: PyTimechart]]
On Tue, 2010-05-18 at 11:16 -0400, Mathieu Desnoyers wrote:
> > Also, suppose it was still in the page-cache and still dirty, a steal()
> > would then punch a hole in the file.
> page_cache_pipe_buf_steal starts by doing a wait_on_page_writeback(page); and
> then does a try_to_release_page(page, GFP_KERNEL). Only if that succeeds is the
> action of stealing succeeding.

If you're going to wait for writeback I don't really see the advantage
of stealing over simply allocating a new page.

 \ /
  Last update: 2010-05-18 17:27    [W:0.038 / U:1.824 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site