lkml.org 
[lkml]   [2010]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/3] posix_timer: move copy_to_user(created_timer_id) down in timer_create
    On 05/18, Stanislaw Gruszka wrote:
    >
    > On Mon, 17 May 2010 21:18:08 +0400
    > Andrey Vagin <avagin@openvz.org> wrote:
    >
    > > According to Oleg Nesterov:
    > > We can move copy_to_user(created_timer_id) down after
    > > "if (timer_event_spec)" block too. (but before CLOCK_DISPATCH(),
    > > of course).
    >
    > I'm not sure what for Oleg want that change, I'm not seeing any value of
    > it. I think patch should be dropped.

    I didn't mean this change is really needed. I just wanted to clarify
    that currently the comment is wrong.

    But. Now that we move CLOCK_DISPATCH() down, it becomes correct again:
    we report created_timer_id to user-space despite the fact timer_create()
    can fail later. This _perhaps_ means it makes sense to preserve the
    comment and move the copy_to_user() block down, before CLOCK_DISPATCH(),
    just to make the code more readable/understandable.

    But I agree with either way you and Andrey prefer. And I believe 2/3
    should fix the problem correctly.

    Oleg.



    \
     
     \ /
      Last update: 2010-05-18 16:29    [W:0.051 / U:1.596 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site