lkml.org 
[lkml]   [2010]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH -next] bridge: fix build for CONFIG_SYSFS disabled
From
From: Randy Dunlap <randy.dunlap@oracle.com>
Date: Mon, 17 May 2010 11:01:12 -0700

> On 05/17/10 10:56, Stephen Hemminger wrote:
>> On Mon, 17 May 2010 09:17:56 -0700
>> Randy Dunlap <randy.dunlap@oracle.com> wrote:
>>
>>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>>
>>> Fix build when CONFIG_SYSFS is not enabled:
>>>
>>> net/bridge/br_if.c:136: error: 'struct net_bridge_port' has no member named 'sysfs_name'
>>>
>>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
...
>> I don't like peppering code with #ifdef like this.
>
> Thanks. I didn't like it either.
>
>> Turns out that in this place sysfs_name is always the same
>> as the device name so instead:

Stephen, please give me a formal submission of this fix with proper
signoff and credit to Randy.

Thanks!


\
 
 \ /
  Last update: 2010-05-18 07:35    [W:0.048 / U:5.084 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site