lkml.org 
[lkml]   [2010]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [tip:perf/core] perf probe: Don't compile CFI related code if elfutils is old
From
On Tue, May 18, 2010 at 11:35 AM, Robert Richter <robert.richter@amd.com> wrote:
> On 17.05.10 21:57:38, tip-bot for Masami Hiramatsu wrote:
>> Commit-ID:  7752f1b096e13991f20b59fd11ba73da3809d93c
>> Gitweb:     http://git.kernel.org/tip/7752f1b096e13991f20b59fd11ba73da3809d93c
>> Author:     Masami Hiramatsu <mhiramat@redhat.com>
>> AuthorDate: Mon, 10 May 2010 13:12:07 -0400
>> Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
>> CommitDate: Mon, 17 May 2010 22:13:51 -0300
>>
>> perf probe: Don't compile CFI related code if elfutils is old
>>
>> Check elfutils version, and if it is old don't compile CFI analysis code. This
>> allows to compile perf with old elfutils.
>>
>> Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
>> Tested-by: Stephane Eranian <eranian@google.com>
>> Reported-by: Robert Richter <robert.richter@amd.com>
>> Cc: Ingo Molnar <mingo@elte.hu>
>> LKML-Reference: <20100510171207.26029.97604.stgit@localhost6.localdomain6>
>> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>> ---
>
> I think this patch is not needed as we came up with an alternative
> solution with commit:
>
>  6b3c4ef perf probe: Check older elfutils and set NO_DWARF
>
But I am compiling tip, so this patch is in and I still got the problem.
It is because the test program does not check for Dwarf_CFI so it
assumes you have the right version of libdw.

If I understand Masami's patch, you can still compile dwarf support
in despite the lack of Dwarf_CFI.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-05-18 11:43    [W:0.100 / U:5.620 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site