lkml.org 
[lkml]   [2010]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[tip:perf/core] perf symbols: symbol inconsistency message should be done only at verbose=1
Commit-ID:  2f51903bc3139e25ec908f8944a0001c7b868e90
Gitweb: http://git.kernel.org/tip/2f51903bc3139e25ec908f8944a0001c7b868e90
Author: Arnaldo Carvalho de Melo <acme@redhat.com>
AuthorDate: Mon, 17 May 2010 17:57:59 -0300
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 17 May 2010 17:57:59 -0300

perf symbols: symbol inconsistency message should be done only at verbose=1

That happened for an old perf.data file that had no fake MMAP events for
the kernel modules, but even then it should warn once for each module,
not one time for every symbol in every module not found.

Reported-by: Ingo Molnar <mingo@elte.hu>
LKML-Reference: <new-submission>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/symbol.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index ecccc8d..a06131f 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -525,7 +525,7 @@ static int dso__split_kallsyms(struct dso *self, struct map *map,
curr_map = map_groups__find_by_name(kmaps,
map->type, module);
if (curr_map == NULL) {
- pr_err("%s/proc/{kallsyms,modules} "
+ pr_debug("%s/proc/{kallsyms,modules} "
"inconsistency while looking "
"for \"%s\" module!\n",
machine->root_dir, module);

\
 
 \ /
  Last update: 2010-05-17 23:13    [W:0.030 / U:0.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site