Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH v3 00/10] BKL conversion in tty layer | Date | Mon, 17 May 2010 20:49:56 +0200 |
| |
On Monday 17 May 2010, Alan Cox wrote: > At this point I think the only way to make further progress is to > actually push this stuff into the kernel on top of the BKL removal > patches for the drivers and see what happens. Something will no doubt > break but we can try and nail them in time or if not revert the series > and try again next kernel.
Ok, thanks. Most of the breakage that I've seen while testing this (after I first got it working) was either trivially breaking the build, or causing lockdep splats for things that are correct with CONFIG_TTY_MUTEX disabled but violating the lock order with it enabled.
I'm ok with having the series in -next for another kernel to improve the quality, as long as no new major changes to the tty locking get merged that break the assumptions I made. Your last series did make my work easier (or maybe even possible) to get to this point, but most of the time was spent checking every possible code path by hand to validate the locking rules, and that would need to be done again if the code changes.
Arnd
| |