lkml.org 
[lkml]   [2010]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/3] posix_timer: fix error path in timer_create
    Date
    move CLOCK_DISPATCH(which_clock, timer_create, (new_timer)) after all
    posible EFAULT erros.

    *_timer_create may allocate/get resources.
    (for example posix_cpu_timer_create does get_task_struct)

    Signed-off-by: Andrey Vagin <avagin@openvz.org>
    ---
    kernel/posix-timers.c | 7 ++++---
    1 files changed, 4 insertions(+), 3 deletions(-)

    diff --git a/kernel/posix-timers.c b/kernel/posix-timers.c
    index 5555e7c..ad72342 100644
    --- a/kernel/posix-timers.c
    +++ b/kernel/posix-timers.c
    @@ -559,9 +559,6 @@ SYSCALL_DEFINE3(timer_create, const clockid_t, which_clock,
    new_timer->it_id = (timer_t) new_timer_id;
    new_timer->it_clock = which_clock;
    new_timer->it_overrun = -1;
    - error = CLOCK_DISPATCH(which_clock, timer_create, (new_timer));
    - if (error)
    - goto out;

    if (copy_to_user(created_timer_id,
    &new_timer_id, sizeof (new_timer_id))) {
    @@ -593,6 +590,10 @@ SYSCALL_DEFINE3(timer_create, const clockid_t, which_clock,
    new_timer->sigq->info.si_tid = new_timer->it_id;
    new_timer->sigq->info.si_code = SI_TIMER;

    + error = CLOCK_DISPATCH(which_clock, timer_create, (new_timer));
    + if (error)
    + goto out;
    +
    spin_lock_irq(&current->sighand->siglock);
    new_timer->it_signal = current->signal;
    list_add(&new_timer->list, &current->signal->posix_timers);
    --
    1.6.6


    \
     
     \ /
      Last update: 2010-05-17 19:21    [W:0.021 / U:29.404 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site