Messages in this thread | | | Date | Mon, 17 May 2010 09:07:55 -0700 | From | jacob pan <> | Subject | Re: [PATCH 2/8] x86/mrst: add cpu type detection for Medfield |
| |
> >Why are you having mrst_cpu_chip as a caching variable if you expose >the identify function ? Either you evaluate boot_cpu_data everytime or >you do it once and expose a function which lets you access the cached >data. IIRC Alan mentioned that drivers need this info, so the access >function will need an EXPORT_SYMBOL_GPL to work. >
I cached value because mrst_cpu_chip is used a few times in mrst.c, I should fix that to have a unified interface. will also do the EXPORT_SYMBOL_GPL.
thanks.
| |