lkml.org 
[lkml]   [2010]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Typo in drivers/base/core.c
On Mon, May 17, 2010 at 04:57:58PM +0200, Christoph Egger wrote:
> Hi all!
>
> As part of the VAMOS[0] research project at the University of
> Erlangen we are looking at multiple integrity errors in linux'
> configuration system.
>
> There's a typo in linux' source (CONFIG_MODULE -- missing the
> final S) making the whole codeblock unselectable. The included patch
> should address this issue.

Heh, this has been there since the code went into the tree, way back in
2.6.29 (1 1/2 years ago). Nice fine, I'll queue it up later this week.

Mark, how did you ever test this?

thanks,

greg k-h

> >From d5fe80140757fedfe19c293cd7af4c1030b92353 Mon Sep 17 00:00:00 2001
> From: Christoph Egger <siccegge@cs.fau.de>
> Date: Mon, 17 May 2010 16:48:59 +0200
> Subject: [PATCH] CONFIG_MODULES misstyped as _MODULE
>
> In this code section the final S of CONFIG_MODULES was missed making
> the whole check useless
>
> Signed-off-by: Christoph Egger <siccegge@cs.fau.de>
> ---
> drivers/base/core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index b56a0ba..f801c36 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -1372,7 +1372,7 @@ struct device *__root_device_register(const char *name, struct module *owner)
> return ERR_PTR(err);
> }
>
> -#ifdef CONFIG_MODULE /* gotta find a "cleaner" way to do this */
> +#ifdef CONFIG_MODULES /* gotta find a "cleaner" way to do this */
> if (owner) {
> struct module_kobject *mk = &owner->mkobj;
>
> --
> 1.6.3.3
>
>
>
>
>
>
>
>
>
>
>


\
 
 \ /
  Last update: 2010-05-17 17:37    [W:0.027 / U:0.904 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site