Messages in this thread | | | From | Stefan Roese <> | Subject | Re: [PATCH]460EX on-chip SATA driver <Kernel 2.6.33> < resubmission > | Date | Mon, 17 May 2010 12:06:47 +0200 |
| |
Hi Ben,
On Sunday 16 May 2010 01:40:28 Benjamin Herrenschmidt wrote: > > > + SATA0: sata@bffd1000 { > > > + compatible = "amcc,sata-460ex"; > > > + reg = <4 0xbffd1000 0x800 4 0xbffd0800 0x400>; > > > + interrupt-parent = <&UIC3>; > > > + interrupts = <0x0 0x4 /* SATA */ > > > + 0x5 0x4>; /* AHBDMA */ > > > + }; > > > + > > > > > > POB0: opb { > > > > > > compatible = "ibm,opb-460ex", "ibm,opb"; > > > #address-cells = <1>; > > > > Please put the device tree update in a separate patch to go thru the > > > > PowerPC tree. > > Additionally, the boot wrapper should probably either remove the node or > at least use a status property "ok" / "disabled" to represent whether > the board is configured for SATA or PCIe x1...
U-Boot already sets the "status" property of the PCIe or SATA node accordingly. Just let me know if this doesn't work for you.
Cheers, Stefan
| |