lkml.org 
[lkml]   [2010]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: ERR_PTR and PTR_ERR
On Sun, May 16, 2010 at 11:05:23AM +0200, Julia Lawall wrote:
> On Sun, 16 May 2010, Julia Lawall wrote:
>
> > I see a number of occurrences of code like the following:
> >
> > if (IS_ERR(alg))
> > return ERR_PTR(PTR_ERR(alg));
> >
> > Is there any reason why the second line couldn't just be return alg?
>
> Hmm, never mind. It seems to address a type problem.

More idiomatic way to deal with that is ERR_CAST(); see e.g. ext2_lookup() for
use case:
...
inode = NULL;
if (ino) {
inode = ext2_iget(dir->i_sb, ino);
if (unlikely(IS_ERR(inode))) {
if (PTR_ERR(inode) == -ESTALE) {
ext2_error(dir->i_sb, __func__,
"deleted inode referenced: %lu",
(unsigned long) ino);
return ERR_PTR(-EIO);
} else {
return ERR_CAST(inode);
}
}
}
return d_splice_alias(inode, dentry);



\
 
 \ /
  Last update: 2010-05-16 19:39    [W:0.039 / U:0.680 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site