lkml.org 
[lkml]   [2010]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] mm: Consider the entire user address space during node migration
From
Hi

Mysteriously, I haven't receive original post.
So now I'm guessing you acked following patch.

http://lkml.org/lkml/2010/5/14/393

but I don't think it is correct.

> - check_range(mm, mm->mmap->vm_start, TASK_SIZE, &nmask,
> + check_range(mm, mm->mmap->vm_start, TASK_SIZE_MAX, &nmask,
> flags | MPOL_MF_DISCONTIG_OK, &pagelist);

Because TASK_SIZE_MAX is defined on x86 only. Why can we ignore other platform?
Please put following line anywhere.

#define TASK_SIZE_MAX TASK_SIZE


But this patch is conceptually good. if it fixes the bug. I'll ack gladly.

Thanks.


\
 
 \ /
  Last update: 2010-05-15 16:33    [from the cache]
©2003-2011 Jasper Spaans