Messages in this thread | | | Date | Fri, 14 May 2010 12:11:36 +0800 | From | Wu Fengguang <> | Subject | Re: [RFC, 3/7] NUMA hotplug emulator |
| |
> Pls. replace it with following code: > > +#ifdef CONFIG_NODE_HOTPLUG_EMU > +static ssize_t store_nodes_probe(struct sysdev_class *class, > + struct sysdev_class_attribute *attr, > + const char *buf, size_t count) > +{ > + long nid; > + int ret; > + > + ret = strict_strtol(buf, 0, &nid); > + if (ret == -EINVAL) > + return ret; > + > + ret = hotadd_hidden_nodes(nid); > + if (!ret) > + return count; > + else > + return -EIO; > +} > +#endif
How about this?
err = strict_strtol(buf, 0, &nid); if (err < 0) return err;
err = hotadd_hidden_nodes(nid); if (err < 0) return err;
return count;
Thanks, Fengguang
| |