lkml.org 
[lkml]   [2010]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 07/37] lmb: Add lmb_find_area()
From
Date
On Fri, 2010-05-14 at 12:45 -0700, Yinghai Lu wrote:
> it is a wrapper for lmb_find_base
>
> make it more easy for x86 to use lmb. ( rebase )
> x86 early_res is using find/reserve pattern instead of alloc.
>
> keep it in weak version, so later We can use x86 own version if needed.
> also We need it in lib/lmb.c, so one called mm/page_alloc.c could get compiled

I seem to have told you that I didn't want to have that thing in the
core :-)

You keep adding those "wrappers" which basically just do prototype
adaptation and in this case a bit of cropping, with a name that is
utterly confusing as to what their intent is.

I might have accepted that one if you had called it something like
lmb_find_in_range() which at least -means- something.

Cheers,
Ben.

> -v2: Change name to lmb_find_area() according to Michael Ellerman
> -v3: Add generic weak version __lmb_find_area()
> so keep the path for fallback to x86 version that handle from low
> -v4: use 0 for failing path
> -v5: use LMB_ERROR again
>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
> ---
> include/linux/lmb.h | 4 ++++
> lib/lmb.c | 23 +++++++++++++++++++++++
> 2 files changed, 27 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/lmb.h b/include/linux/lmb.h
> index e54c1d0..c05294f 100644
> --- a/include/linux/lmb.h
> +++ b/include/linux/lmb.h
> @@ -44,6 +44,10 @@ extern struct lmb lmb;
> extern int lmb_debug;
> extern struct lmb_region lmb_reserved_init_regions[];
>
> +u64 __lmb_find_area(u64 ei_start, u64 ei_last, u64 start, u64 end,
> + u64 size, u64 align);
> +u64 lmb_find_area(u64 start, u64 end, u64 size, u64 align);
> +
> extern void __init lmb_init(void);
> extern void __init lmb_analyze(void);
> extern long lmb_add(phys_addr_t base, phys_addr_t size);
> diff --git a/lib/lmb.c b/lib/lmb.c
> index c92034b..1c46336 100644
> --- a/lib/lmb.c
> +++ b/lib/lmb.c
> @@ -155,6 +155,29 @@ static phys_addr_t __init lmb_find_base(phys_addr_t size, phys_addr_t align,
> return LMB_ERROR;
> }
>
> +u64 __init __weak __lmb_find_area(u64 ei_start, u64 ei_last, u64 start, u64 end,
> + u64 size, u64 align)
> +{
> + u64 final_start, final_end;
> + u64 mem;
> +
> + final_start = max(ei_start, start);
> + final_end = min(ei_last, end);
> +
> + if (final_start >= final_end)
> + return LMB_ERROR;
> +
> + return lmb_find_base(size, align, final_start, final_end);
> +}
> +
> +/*
> + * Find a free area with specified alignment in a specific range.
> + */
> +u64 __init __weak lmb_find_area(u64 start, u64 end, u64 size, u64 align)
> +{
> + return lmb_find_base(size, align, start, end);
> +}
> +
> static void __init_lmb lmb_remove_region(struct lmb_type *type, unsigned long r)
> {
> unsigned long i;




\
 
 \ /
  Last update: 2010-05-15 00:43    [from the cache]
©2003-2011 Jasper Spaans