Messages in this thread | | | Subject | Re: [PATCH] MMC: OMAP HS-MMC: convert to dev_pm_ops | From | Kevin Hilman <> | Date | Fri, 14 May 2010 09:51:21 -0700 |
| |
Matt Fleming <matt@console-pimps.org> writes:
> On Tue, 11 May 2010 14:57:16 -0700, Kevin Hilman <khilman@deeprootsystems.com> wrote: >> >> Note that dev_pm_ops version of the suspend hook no longer takes a >> 'state' argument. However, the MMC core function mmc_suspend_host() >> still takes a 'state' argument, but it is unused, so a dummy >> state variable was created to pass to the MMC core. > > Hmm.. instead of passing this dummy state argument why don't we just > remove the argument from mmc_suspend_host()? Like you said, it's unused, > so I don't see a reason to keep it around?
I don't see a reason either, but it requires patching the MMC core as well as all the users. As I'm not an MMC core person, I thought this best left to someone in that domain.
Fixing the core and callers could easily be done on top of this patch.
Kevin
| |