lkml.org 
[lkml]   [2010]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 08/35] x86,lmb: Add lmb_reserve_area/lmb_free_area
From
Date
On Thu, 2010-05-13 at 23:30 -0700, Yinghai wrote:
> make the rebase more easy.
>
> previous version is using those api.
>
> also will add some debug print out with them

No. Get rid of them.

If any of those checks/debug is worth having in the API it's worth
having it for all archs.

At -worst-, Thomas and Peter may be ok with having inline wrappers for
the argument style conversion in x86 lmb.h but I somewhat doubt it.

In the form of non-inline exported functions with such confusing naming
and semantics (and total lack of documentation or explanation), this is
just wrong.

Cheers,
Ben.




\
 
 \ /
  Last update: 2010-05-14 10:19    [W:0.159 / U:0.176 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site