lkml.org 
[lkml]   [2010]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC tip/core/rcu 02/23] rcu: add __rcu API for later sparse checking
On Wed, May 12, 2010 at 02:33:21PM -0700, Paul E. McKenney wrote:
> This commit defines an __rcu API, but provides only vacuous definitions
> for it. This breaks dependencies among most of the subsequent patches,
> allowing them to reach mainline asynchronously via whatever trees are
> appropriate.

Seems like a good plan to me.

I know it's not the right time to push it but I am curious to see what,
approximately, you expect a non-vacuous __rcu definition to look like.
(i.e. when it's being run through sparse)

Cheers,
-Matt Helsley

>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Cc: Christopher Li <sparse@chrisli.org>
> Cc: Josh Triplett <josh@joshtriplett.org>
> ---
> include/linux/compiler.h | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/compiler.h b/include/linux/compiler.h
> index a5a472b..c1a62c5 100644
> --- a/include/linux/compiler.h
> +++ b/include/linux/compiler.h
> @@ -16,6 +16,7 @@
> # define __release(x) __context__(x,-1)
> # define __cond_lock(x,c) ((c) ? ({ __acquire(x); 1; }) : 0)
> # define __percpu __attribute__((noderef, address_space(3)))
> +# define __rcu
> extern void __chk_user_ptr(const volatile void __user *);
> extern void __chk_io_ptr(const volatile void __iomem *);
> #else
> @@ -34,6 +35,7 @@ extern void __chk_io_ptr(const volatile void __iomem *);
> # define __release(x) (void)0
> # define __cond_lock(x,c) (c)
> # define __percpu
> +# define __rcu
> #endif
>
> #ifdef __KERNEL__
> --
> 1.7.0.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/


\
 
 \ /
  Last update: 2010-05-13 22:55    [W:0.143 / U:8.172 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site