Messages in this thread | | | Date | Thu, 13 May 2010 13:29:53 -0700 | From | Randy Dunlap <> | Subject | Re: [PATCH] TPM: ACPI/PNP dependency removal |
| |
Rajiv Andrade wrote: > This patch pushes the ACPI dependency into the device driver code > itself. Now, even without ACPI/PNP enabled, the device can be registered > using the TIS specified memory space. This will however result in the > lack of access to the bios event log, being the only implication of such > ACPI removal. > > Signed-off-by: Rajiv Andrade <srajiv@linux.vnet.ibm.com> > Acked-by: Mimi Zohar <zohar@linux.vnet.ibm.com> > --- > drivers/char/tpm/Kconfig | 6 ++++-- > drivers/char/tpm/tpm_tis.c | 42 ++++++++++++++++++++++-------------------- > 2 files changed, 26 insertions(+), 22 deletions(-) > > diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig > index f5fc64f..fffc994 100644 > --- a/drivers/char/tpm/Kconfig > +++ b/drivers/char/tpm/Kconfig > @@ -17,14 +17,16 @@ menuconfig TCG_TPM > obtained at: <http://sourceforge.net/projects/trousers>. To > compile this driver as a module, choose M here; the module > will be called tpm. If unsure, say N. > - Note: For more TPM drivers enable CONFIG_PNP, CONFIG_ACPI > + Notes: > + 1) For more TPM drivers enable CONFIG_PNP, CONFIG_ACPI > and CONFIG_PNPACPI. > + 2) Without ACPI enabled, the bios event log won't be accessible,
s/bios/BIOS/ please
> + which is required to validate the PCR 0-7 values. > > if TCG_TPM > > config TCG_TIS > tristate "TPM Interface Specification 1.2 Interface" > - depends on PNP > ---help--- > If you have a TPM security chip that is compliant with the > TCG TIS 1.2 TPM specification say Yes and it will be accessible
Thanks for the update.
| |