lkml.org 
[lkml]   [2010]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 7/11] Uprobes Implementation
On 05/11, Peter Zijlstra wrote:
>
> On Thu, 2010-04-22 at 17:40 +0200, Oleg Nesterov wrote:
> >
> > Either way, I think register_uprobe() should disallow the probes in
> > VM_SHARED/VM_MAYWRITE vmas.
>
> VM_SHARED, fully agreed, MAYWRITE not so sure, MAP_PRIVATE has MAYWRITE
> iirc and its perfectly fine to poke at those.

Yes, sorry for confusion. Not sure where this VM_MAYWRITE came from.

But I still think this doesn't actually matter, replace_page() shouldn't
preserve the mapping, it should always install the anonymous page. I can
be wrong, of course.

(I didn't read the next version yet)

Oleg.



\
 
 \ /
  Last update: 2010-05-13 21:47    [W:0.309 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site