lkml.org 
[lkml]   [2010]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC, 6/7] NUMA hotplug emulator
On Thu, May 13, 2010 at 11:02:17AM -0700, Dave Hansen wrote:
> On Thu, 2010-05-13 at 09:56 -0700, Greg KH wrote:
> > On Thu, May 13, 2010 at 08:00:16PM +0800, Shaohui Zheng wrote:
> > > hotplug emulator:extend memory probe interface to support NUMA
> > >
> > > Extend memory probe interface to support an extra paramter nid,
> > > the reserved memory can be added into this node if node exists.
> > >
> > > Add a memory section(128M) to node 3(boots with mem=1024m)
> > >
> > > echo 0x40000000,3 > memory/probe
>
> I dunno. If we're going to put multiple values into the file now and
> add to the ABI, can we be more explicit about it?
>
> echo "physical_address=0x40000000 numa_node=3" > memory/probe
>
> I'd *GREATLY* prefer that over this new syntax. The existing mechanism
> is obtuse enough, and the ',3' makes it more so.
>
> We should have the code around to parse arguments like that, too, since
> we use it for the boot command-line.

If you are going to be doing something like this, please use configfs,
that is what it is designed for, not sysfs.

thanks,

greg k-h


\
 
 \ /
  Last update: 2010-05-13 20:47    [W:0.093 / U:0.624 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site