lkml.org 
[lkml]   [2010]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 03/25] lmb: Introduce for_each_lmb() and new accessors, and use it
    From
    Date
    On Mon, 2010-05-10 at 17:39 +0200, Thomas Gleixner wrote:
    > > +#define for_each_lmb(lmb_type, region) \
    > > + for (reg = lmb.lmb_type.regions; \
    > > + region < (lmb.lmb_type.regions + lmb.lmb_type.cnt); \
    > > + region++)
    > > +
    >
    > Can you please make this:
    >
    > #define for_each_lmb(lmb_type, region, __iter) \
    > for (__iter = lmb.lmb_type.regions; \
    > region < (lmb.lmb_type.regions + lmb.lmb_type.cnt); \
    > region++)
    >
    > so we do not have the iterator name hardcoded inside the macro body.

    As a matter of fact, we didn't, but I made a typo on the first one:

    - for (reg = lmb.lmb_type.regions; \
    + for (region = lmb.lmb_type.regions; \
    region < (lmb.lmb_type.regions + lmb.lmb_type.cnt); \
    region++)

    I'll fix that in my series.

    Cheers,
    Ben.



    \
     
     \ /
      Last update: 2010-05-12 09:53    [W:0.028 / U:0.052 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site