Messages in this thread | | | Date | Wed, 12 May 2010 18:12:38 -0700 | Subject | Re: [PATCH 04/12] rwsem: consistently use adjustment variable | From | Michel Lespinasse <> |
| |
On Wed, May 12, 2010 at 4:45 AM, David Howells <dhowells@redhat.com> wrote: > From a human point of view, I would say keep woken, but use it to initialise > adjustment: > > adjustment = woken * RWSEM_ACTIVE_READ_BIAS; > > and use it to initialise 'loop': > > for (loop = woken; loop > 0; loop--) {
Sounds good. I'll have it in next version.
(Arguably 'woken' might be confusing too given that we only wake the threads later on. But I don't care much either way).
-- Michel "Walken" Lespinasse A program is never fully debugged until the last user dies. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |