[lkml]   [2010]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[patch] libsas: dereferencing variable before check
The "qc->scsicmd" could be null so I moved the dereference inside the
check. This was introduced by 70b25f890: "[SCSI] fix locking around

Signed-off-by: Dan Carpenter <>

diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
index 88f7446..98b1545 100644
--- a/drivers/scsi/libsas/sas_ata.c
+++ b/drivers/scsi/libsas/sas_ata.c
@@ -395,12 +395,13 @@ int sas_ata_init_host_and_port(struct domain_device *found_dev,
void sas_ata_task_abort(struct sas_task *task)
struct ata_queued_cmd *qc = task->uldd_task;
- struct request_queue *q = qc->scsicmd->device->request_queue;
+ struct request_queue *q;
struct completion *waiting;
unsigned long flags;

/* Bounce SCSI-initiated commands to the SCSI EH */
if (qc->scsicmd) {
+ q = qc->scsicmd->device->request_queue;
spin_lock_irqsave(q->queue_lock, flags);
spin_unlock_irqrestore(q->queue_lock, flags);

 \ /
  Last update: 2010-05-13 00:59    [W:0.041 / U:20.328 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site