Messages in this thread | | | Date | Wed, 12 May 2010 15:14:34 -0700 | From | Greg KH <> | Subject | Re: [stable] [171/197] module: fix __module_ref_addr() |
| |
On Wed, Apr 28, 2010 at 10:29:44AM -0700, Greg KH wrote: > On Wed, Apr 28, 2010 at 07:24:13PM +0200, Tejun Heo wrote: > > On 04/28/2010 06:55 PM, Jiri Benc wrote: > > > On Wed, 28 Apr 2010 12:20:56 -0400, Mathieu Desnoyers wrote: > > >> Can you try reverting commit c8d52465f95c4187871f8e65666c07806ca06d41 and see if > > >> it helps ? > > > > > > It doesn't. The produced code is identical. > > > > > >> If you have other compiler versions handy, that would also be helpful to see if > > >> the problem is specific to the gcc version you are using. > > > > > > Tried 4.5.0, the same problem (at least looking at the produced assembler > > > code, I haven't booted the kernel, but it looks very similar to 4.3.3). > > > > I wrote on the bugzilla but this is not a compiler bug but the -stable > > patch shouldn't have been applied only to 2.6.33. Not 2.6.32. This > > is because till 2.6.32, ia64 hadn't been converted to dynamic percpu > > allocator, so its static and dynamic percpu areas were separate and > > the per_cpu_ptr() wouldn't do the offsetting the module code expects > > there. So, please revert the patch from 2.6.32. > > Ah crap, I missed that. I'll go revert it from .32 now, sorry about > that.
And of course, I forgot to do that before releasing the next .32 kernel. It will be in the one after this one. bah.
greg k-h
| |