lkml.org 
[lkml]   [2010]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/4] pids: init_struct_pid.tasks should never see the swapper process
    On 05/11, Serge E. Hallyn wrote:
    >
    > Quoting Oleg Nesterov (oleg@redhat.com):
    > > Change INIT_STRUCT_PID/INIT_PID_LINK to create the empty/unhashed
    > > hlist_head/hlist_node. Like any other idle thread swapper can never exit,
    > > so detach_pid()->__hlist_del() is not possible, but we could change
    > > INIT_PID_LINK() to set pprev = &next if needed.
    > >
    > > All we need is the valid swapper->pids[].pid == &init_struct_pid.
    > >
    > > Reported-by: Mathias Krause <mathias.krause@secunet.com>
    >
    > Crimey, trying to find some way this could get dereferenced,

    Yes, I was worried too. But afaics we should never use this hlist_node.
    Except, of course, it is linked into pid->task.

    > finding
    > myself impressed with the likes of set_ftrace_swapper().
    >
    > Anyway, not finding anything, so
    >
    > > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
    >
    > Acked-by: Serge E. Hallyn <serue@us.ibm.com>

    Thanks for review!

    Oleg.



    \
     
     \ /
      Last update: 2010-05-12 18:09    [W:0.021 / U:2.676 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site