[lkml]   [2010]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/3] pda_power: add support for writeable properties
On Tue, May 11, 2010 at 07:58:12PM +0200, Daniel Mack wrote:
> Hmm, no. The code defaults to (S_IRUSR | S_IRGRP | S_IROTH) which is
> 0444, just like it was before. So there shouldn't be any regression. The
> mode is only changed if the psy defines a property_is_writeable()
> callback which returns 1. Or do I miss your point?

Yes, power_supply_attrs is a global array, and you shouldn't change
it between power_supply_register() calls.

If you don't see why it's a bad idea in general, think about it
other way, a race:

...someone registers psy0 with attr X marked as read-only...
...code flow stops before device_create_file(psy0, global->mode)..
...someone registers psy1 with attr X marked as writable... set up global->mode to 0644...
[preempt again]
...we end up calling device_create_file(psy0, 0644)...

Anton Vorontsov

 \ /
  Last update: 2010-05-12 10:17    [W:0.213 / U:23.568 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site