lkml.org 
[lkml]   [2010]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv5 2/3] OMAP: export OMAP info under /proc/socinfo
Eduardo Valentin had written, on 05/11/2010 09:15 AM, the following:
> From: Eduardo Valentin <eduardo.valentin@nokia.com>
>
> Export OMAP name and rev under /proc/socinfo node.
>
> Signed-off-by: Eduardo Valentin <eduardo.valentin@nokia.com>
> ---
> arch/arm/Kconfig | 1 +
> arch/arm/mach-omap1/id.c | 31 ++++++++++++++++++++++++-------
> arch/arm/mach-omap2/id.c | 32 ++++++++++++++++++++++++++------
> 3 files changed, 51 insertions(+), 13 deletions(-)
>
[..]

> diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
> index 37b8a1a..b67486b 100644
> --- a/arch/arm/mach-omap2/id.c
> +++ b/arch/arm/mach-omap2/id.c
[..]

> @@ -356,7 +363,8 @@ void __init omap3_cpuinfo(void)
> }
>
> /* Print verbose information */
> - pr_info("%s ES%s (", cpu_name, cpu_rev);
> + snprintf(socinfo, SOCINFO_SZ, "%s ES%s", cpu_name, cpu_rev);
> + pr_info("%s (", socinfo);
>
> OMAP3_SHOW_FEATURE(l2cache);
> OMAP3_SHOW_FEATURE(iva);
Just a minor comment -> is it a good idea to pushin the features to SOC
info as well? currently this is being displayed at bootlog and not
beyond.. might be a better approach to move it into socinfo..


[..]

--
Regards,
Nishanth Menon


\
 
 \ /
  Last update: 2010-05-12 10:11    [from the cache]
©2003-2011 Jasper Spaans