lkml.org 
[lkml]   [2010]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [107/117] ACPI: DMI init_set_sci_en_on_resume for multiple Lenovo ThinkPads
Hm, this patch looks a little wonky.

Why is every entry repeated 3x?

> + .callback = init_set_sci_en_on_resume,
> + .ident = "Lenovo ThinkPad T410",

[snip]

> + .callback = init_set_sci_en_on_resume,
> + .ident = "Lenovo ThinkPad T410",

[snip[

> + .callback = init_set_sci_en_on_resume,
> + .ident = "Lenovo ThinkPad T410",

Oh crap, it's broken upstream too. :(

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=patch;h=07bedca29b0973f36a6b6db36936deed367164ed

Not sure what happened, but I think some sort of hiccup occurred
when the patch was applied, since this is what hit the mailing
lists:

https://patchwork.kernel.org/patch/94711/

Len, Greg, what would you like me to do? I think the cleanest
thing to do to help keep -stable clean would be to:

a) drop this patch from current -stable queue
b) revert 07bedca29b09 upstream
c) apply the patch from patchwork
d) re-apply to -stable

Thoughts?

Thanks,
/ac


\
 
 \ /
  Last update: 2010-05-12 11:27    [from the cache]
©2003-2011 Jasper Spaans