lkml.org 
[lkml]   [2010]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[102/117] security: testing the wrong variable in create_by_name()
    2.6.33-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Dan Carpenter <error27@gmail.com>

    commit b338cc8207eae46640a8d534738fda7b5e48511d upstream.

    There is a typo here. We should be testing "*dentry" instead of
    "dentry". If "*dentry" is an ERR_PTR, it gets dereferenced in either
    mkdir() or create() which would cause an OOPs.

    Signed-off-by: Dan Carpenter <error27@gmail.com>
    Signed-off-by: James Morris <jmorris@namei.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    security/inode.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/security/inode.c
    +++ b/security/inode.c
    @@ -161,13 +161,13 @@ static int create_by_name(const char *na

    mutex_lock(&parent->d_inode->i_mutex);
    *dentry = lookup_one_len(name, parent, strlen(name));
    - if (!IS_ERR(dentry)) {
    + if (!IS_ERR(*dentry)) {
    if ((mode & S_IFMT) == S_IFDIR)
    error = mkdir(parent->d_inode, *dentry, mode);
    else
    error = create(parent->d_inode, *dentry, mode);
    } else
    - error = PTR_ERR(dentry);
    + error = PTR_ERR(*dentry);
    mutex_unlock(&parent->d_inode->i_mutex);

    return error;



    \
     
     \ /
      Last update: 2010-05-12 10:17    [W:4.254 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site