Messages in this thread | | | Date | Mon, 10 May 2010 15:57:29 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH -tip] perf probe: Don't compile CFI related code if elfutils is old |
| |
Em Mon, May 10, 2010 at 08:36:54PM +0200, Robert Richter escreveu: > On 10.05.10 13:28:54, Arnaldo Carvalho de Melo wrote: > > Em Mon, May 10, 2010 at 01:12:07PM -0400, Masami Hiramatsu escreveu: > > > Check elfutils version, and if it is old don't compile CFI > > > analysis code. This allows to compile perf with old elfutils.
> > _ELFUTILS_PREREQ was introduced in:
> > commit fbc7245df72ce0142f0a21fa0f4f88c97278bf60 > > Author: Roland McGrath <roland@redhat.com> > > Date: Tue Dec 16 17:03:03 2008 -0800
> > Which was released in elfutils 0.138, guess this is coverage enough? > > Richard, which version is in your machine?
> Right, this does not work, I am using 0.131. As expected, > "_ELFUTILS_PREREQ" is not defined:
> util/probe-finder.h:47:5: error: "_ELFUTILS_PREREQ" is not defined > util/probe-finder.h:47:21: error: missing binary operator before token "(" > make: *** [builtin-probe.o] Error 1
> Why not create a compile test as for NO_DWARF in tools/perf/Makefile?
Right, that would be better.
- Arnaldo
| |