Messages in this thread | | | Date | Mon, 10 May 2010 15:31:18 -0400 | From | Konrad Rzeszutek Wilk <> | Subject | Re: [PATCH 2/6] swiotlb: swiotlb_tbl_map_single: abstract out swiotlb_virt_to_bus calls out. |
| |
On Sun, May 09, 2010 at 10:41:15PM +0900, FUJITA Tomonori wrote: > On Wed, 7 Apr 2010 16:29:26 -0400 > Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote: > > > We want to move that function out of swiotlb_tbl_map_single so that the caller > > of this function does the virt->phys->bus address translation. > > > > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > > --- > > lib/swiotlb.c | 22 ++++++++++++++-------- > > 1 files changed, 14 insertions(+), 8 deletions(-) > > It would be better to do something like that instead of spreading > swiotlb_virt_to_bus()?
Yes! Thought I am confused by the name. In the past you mentioned 'tbl', but here it is 'tlb'. I presume 'tbl' is the right one?
> Subject: [PATCH] swiotlb: add swiotlb_tlb_map_single library function > > swiotlb_tlb_map_single() takes the dma address of iotlb instead of > using swiotlb_virt_to_bus().
| |