lkml.org 
[lkml]   [2010]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 2/3] blkio: Add io_queued and avg_queue_size stats
    On Fri, Apr 9, 2010 at 8:32 AM, Vivek Goyal <vgoyal@redhat.com> wrote:
    >> +void blkiocg_update_request_add_stats(struct blkio_group *blkg,
    >> +                     struct blkio_group *curr_blkg, bool direction,
    >> +                     bool sync)
    >> +{
    >
    > curr_blkg is redundant?

    Missed this comment in my earlier response. No, curr_blkg is not
    redundant since it is used for determining whether we should set
    group_wait_time or not. This argument should really have been added in
    the 3rd patch instead of this one. Unless you really want me to, I'd
    just let it be.

    -Divyesh
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-04-10 04:37    [W:3.249 / U:0.572 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site