lkml.org 
[lkml]   [2010]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 09/12] osst: Use noop_llseek() instead of default_llseek()
    Date
    __os_scsi_tape_open() suggests that llseek() doesn't work:
    "We really want to do nonseekable_open(inode, filp); here, but some
    versions of tar incorrectly call lseek on tapes and bail out if that
    fails. So we disallow pread() and pwrite(), but permit lseeks."

    Instead of using the fallback default_llseek() the driver should use
    noop_llseek() which leaves the file->f_pos untouched but succeeds.

    Signed-off-by: Jan Blunck <jblunck@suse.de>
    ---
    drivers/scsi/osst.c | 1 +
    1 files changed, 1 insertions(+), 0 deletions(-)

    diff --git a/drivers/scsi/osst.c b/drivers/scsi/osst.c
    index 9dc0b9a..960e39c 100644
    --- a/drivers/scsi/osst.c
    +++ b/drivers/scsi/osst.c
    @@ -5619,6 +5619,7 @@ static const struct file_operations osst_fops = {
    .open = os_scsi_tape_open,
    .flush = os_scsi_tape_flush,
    .release = os_scsi_tape_close,
    + .llseek = noop_llseek,
    };

    static int osst_supports(struct scsi_device * SDp)
    --
    1.6.4.2


    \
     
     \ /
      Last update: 2010-04-09 16:05    [W:0.019 / U:1.188 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site