Messages in this thread Patch in this message | | | From | Jan Blunck <> | Subject | [PATCH 10/12] st: Use noop_llseek() instead of default_llseek() | Date | Fri, 9 Apr 2010 16:00:53 +0200 |
| |
st_open() suggests that llseek() doesn't work: "We really want to do nonseekable_open(inode, filp); here, but some versions of tar incorrectly call lseek on tapes and bail out if that fails. So we disallow pread() and pwrite(), but permit lseeks."
Instead of using the fallback default_llseek() the driver should use noop_llseek() which leaves the file->f_pos untouched but succeeds.
Signed-off-by: Jan Blunck <jblunck@suse.de> --- drivers/scsi/st.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c index f67d1a1..78e8f42 100644 --- a/drivers/scsi/st.c +++ b/drivers/scsi/st.c @@ -3961,6 +3961,7 @@ static const struct file_operations st_fops = .open = st_open, .flush = st_flush, .release = st_release, + .llseek = noop_llseek, }; static int st_probe(struct device *dev) -- 1.6.4.2
| |