Messages in this thread | | | Date | Fri, 09 Apr 2010 11:31:54 +0800 | From | Li Zefan <> | Subject | Re: [PATCH] fix cgroup procs documentation |
| |
Cc: Ben Blum
KAMEZAWA Hiroyuki wrote: > On Fri, 09 Apr 2010 11:22:00 +0800 > Li Zefan <lizf@cn.fujitsu.com> wrote: > >> KAMEZAWA Hiroyuki wrote: >>> 2.6.33's Documentation has the same wrong information. So, I CC'ed to stable. >>> If people believe this information, they'll usr cgroup.procs file and will >>> see cgroup doesn'w work as expected. >>> The patch itself is against -mm. >>> >>> == >>> Writing to cgroup.procs is not supported now. >>> >>> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> >>> --- >>> Documentation/cgroups/cgroups.txt | 3 +-- >>> 1 file changed, 1 insertion(+), 2 deletions(-) >>> >>> Index: mmotm-temp/Documentation/cgroups/cgroups.txt >>> =================================================================== >>> --- mmotm-temp.orig/Documentation/cgroups/cgroups.txt >>> +++ mmotm-temp/Documentation/cgroups/cgroups.txt >>> @@ -235,8 +235,7 @@ containing the following files describin >>> - cgroup.procs: list of tgids in the cgroup. This list is not >>> guaranteed to be sorted or free of duplicate tgids, and userspace >>> should sort/uniquify the list if this property is required. >>> - Writing a tgid into this file moves all threads with that tgid into >>> - this cgroup. >>> + This is a read-only file, now. >> I think the better wording is "for now". :) >> > ok. BTW, does anyone work on this ?
It was Ben Blum, don't know if he's still working on it.
> == > > Writing to cgroup.procs is not supported now. > > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Acked-by: Li Zefan <lizf@cn.fujitsu.com>
> --- > Documentation/cgroups/cgroups.txt | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > Index: mmotm-temp/Documentation/cgroups/cgroups.txt > =================================================================== > --- mmotm-temp.orig/Documentation/cgroups/cgroups.txt > +++ mmotm-temp/Documentation/cgroups/cgroups.txt > @@ -235,8 +235,7 @@ containing the following files describin > - cgroup.procs: list of tgids in the cgroup. This list is not > guaranteed to be sorted or free of duplicate tgids, and userspace > should sort/uniquify the list if this property is required. > - Writing a tgid into this file moves all threads with that tgid into > - this cgroup. > + This is a read-only file, for now. > - notify_on_release flag: run the release agent on exit? > - release_agent: the path to use for release notifications (this file > exists in the top cgroup only) > > >
| |