[lkml]   [2010]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH #3] reiserfs: Fix permissions on .reiserfs_priv
On 04/08/2010 06:39 PM, Matt McCutchen wrote:
> On Thu, 2010-04-08 at 23:38 +0200, Edward Shishkin wrote:
>> Jeff Mahoney wrote:
>>> [...] This patch resolves the issue by properly hiding .reiserfs_priv. This
>>> was the intent of the xattr poisoning code, but it appears to have
>>> never worked as expected. This is fixed by using d_revalidate instead
>>> of d_compare. [...]
> The patch seems to rely on the fact that the priv_root dentry is stuck
> in the dcache for as long as the filesystem is mounted, so that attempts
> to follow ".reiserfs_priv" are guaranteed to match that dentry in the
> cache and be refused by xattr_hide_revalidate. Is my understanding
> correct?

Yes. The other half of it is that the priv_root dentry being stuck in
the dcache for as long as the flie system is mounted is a guaranteed
since REISERFS_SB(sb) holds a reference to it until reiserfs_kill_sb is


Jeff Mahoney
SuSE Labs

 \ /
  Last update: 2010-04-09 02:11    [from the cache]
©2003-2011 Jasper Spaans