lkml.org 
[lkml]   [2010]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] perf_events: fix bogus warn_on(_once) in perf_prepare_sample()
From
On Thu, Apr 8, 2010 at 11:17 PM, Frederic Weisbecker <fweisbec@gmail.com> wrote:
> On Thu, Apr 08, 2010 at 11:14:15PM +0200, Stephane Eranian wrote:
>> On Thu, Apr 8, 2010 at 11:11 PM, Peter Zijlstra <peterz@infradead.org> wrote:
>> > On Thu, 2010-04-08 at 23:08 +0200, Stephane Eranian wrote:
>> >>
>> >> Are you suggesting you add some padding the PEBS raw sample you
>> >> return as PERF_SAMPLE_RAW? Then you need to define what RAW
>> >> actually means? Seems here, it would mean more than what the
>> >> HW returns.
>> >
>> > Well, RAW doesn't mean anything much at all, its really a fugly pass
>> > some crap around thing.
>> >
>> > So yeah, adding padding seems just fine.
>> >
>> I would rather see size as u64. Who's using raw today anyway?
>
>
> The trace events. Hence the size of the size shouldn't be touched, it
> is an ABI now.

Given your alignment constraints, it seems like it was a bad choice to pick
u32 for size to begin with.


\
 
 \ /
  Last update: 2010-04-08 23:25    [W:0.065 / U:0.772 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site