Messages in this thread | | | Date | Thu, 8 Apr 2010 23:14:15 +0200 | Subject | Re: [PATCH] perf_events: fix bogus warn_on(_once) in perf_prepare_sample() | From | Stephane Eranian <> |
| |
On Thu, Apr 8, 2010 at 11:11 PM, Peter Zijlstra <peterz@infradead.org> wrote: > On Thu, 2010-04-08 at 23:08 +0200, Stephane Eranian wrote: >> >> Are you suggesting you add some padding the PEBS raw sample you >> return as PERF_SAMPLE_RAW? Then you need to define what RAW >> actually means? Seems here, it would mean more than what the >> HW returns. > > Well, RAW doesn't mean anything much at all, its really a fugly pass > some crap around thing. > > So yeah, adding padding seems just fine. > I would rather see size as u64. Who's using raw today anyway?
The PEBS record itself is always a multiple of u64. The size header is the one causing the problems.
>
| |