lkml.org 
[lkml]   [2010]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] perf_events: fix bogus warn_on(_once) in perf_prepare_sample()
From
Date
On Thu, 2010-04-08 at 22:45 +0200, Stephane Eranian wrote:
> There is a warn_on_once() check for PERF_SAMPLE_RAW which trips
> when using PEBS on both Core and Nehalem. Core PEBS sample size is 144
> bytes and 176 bytes for Nehalem. Both are multiples of 8, but the size
> field is encoded as int, thus the total is never a multiple of 8 which
> trips the check. I think the size should have been u64, but now it is
> too late to change given it is ABI.

PEBS hasn't seen -linus yet, so we can fix that.

There's various things that do indeed rely on the perf buffer to always
be u64 aligned, so this warning isn't bogus at all.



\
 
 \ /
  Last update: 2010-04-08 22:57    [from the cache]
©2003-2011 Jasper Spaans