lkml.org 
[lkml]   [2010]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    SubjectRe: [REVERT] be6b38bcb175613f239e0b302607db346472c6b6. v2.6.34-rc3-406 oops with 4965AGN wireless
    From
    Date
    Hi Jeff,

    On Thu, 2010-04-08 at 10:16 -0700, Jeff Chua wrote:
    > Linus,
    >
    > I'm having problem with the latest git pull 2 days ago with the 4965AGN
    > wireless.
    >
    > Starting the wireless with WPA2 resulted in system hard freeze. Reverting
    > the commit below solves the problem.
    >
    >
    > Thanks,
    > Jeff
    >
    >
    Sorry for the problem caused by this patch, it is my mistake using the
    similar approach for 4965 like the newer devices. could you try the
    attach patch to see if this fix your system freeze problem.

    Regards
    Wey
    From 0c441b5c684709152cd322e91ce59914159ea513 Mon Sep 17 00:00:00 2001
    From: Wey-Yi Guy <wey-yi.w.guy@intel.com>
    Date: Thu, 8 Apr 2010 11:41:24 -0700
    Subject: [PATCH 1/1] iwlwifi: need check for valid qos packet before free

    For 4965, need to check it is valid qos frame before free, only valid
    QoS frame has the tid used to free the packets.

    Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
    ---
    drivers/net/wireless/iwlwifi/iwl-4965.c | 8 +++++---
    1 files changed, 5 insertions(+), 3 deletions(-)

    diff --git a/drivers/net/wireless/iwlwifi/iwl-4965.c b/drivers/net/wireless/iwlwifi/iwl-4965.c
    index c710b26..4113909 100644
    --- a/drivers/net/wireless/iwlwifi/iwl-4965.c
    +++ b/drivers/net/wireless/iwlwifi/iwl-4965.c
    @@ -2014,7 +2014,9 @@ static void iwl4965_rx_reply_tx(struct iwl_priv *priv,
    IWL_DEBUG_TX_REPLY(priv, "Retry scheduler reclaim scd_ssn "
    "%d index %d\n", scd_ssn , index);
    freed = iwlagn_tx_queue_reclaim(priv, txq_id, index);
    - iwl_free_tfds_in_queue(priv, sta_id, tid, freed);
    + if (qc && likely(sta_id != IWL_INVALID_STATION))
    + iwl_free_tfds_in_queue(priv, sta_id,
    + tid, freed);

    if (priv->mac80211_registered &&
    (iwl_queue_space(&txq->q) > txq->q.low_mark) &&
    @@ -2046,8 +2048,8 @@ static void iwl4965_rx_reply_tx(struct iwl_priv *priv,
    (iwl_queue_space(&txq->q) > txq->q.low_mark))
    iwl_wake_queue(priv, txq_id);
    }
    -
    - iwlagn_txq_check_empty(priv, sta_id, tid, txq_id);
    + if (qc && likely(sta_id != IWL_INVALID_STATION))
    + iwlagn_txq_check_empty(priv, sta_id, tid, txq_id);

    iwl_check_abort_status(priv, tx_resp->frame_count, status);
    }
    --
    1.5.6.3
    \
     
     \ /
      Last update: 2010-04-08 19:57    [W:0.028 / U:32.760 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site