lkml.org 
[lkml]   [2010]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 0/4]-V3 TPS6507x MFD driver
    Hi Todd,

    On Mon, Apr 05, 2010 at 08:23:55PM -0600, Todd Fischer wrote:
    >
    > This is the third posting of the TPS6507x driver set. I have
    > resolved the concurrent access issue identified by Mark Brown.
    > Instead of using a mutex, I used the i2c_transfer() as done in
    > the similar routine in the wm8400-core.c file.
    >
    > The TPS6507x family of Texas Instruments power management ICs (pmic) are
    > multi-function chips that include voltage regulation and touch screen
    > controller capabilities. This patch set adds a TPS6507x multi-function
    > device driver and change the TPS6507x regulator driver to use the
    > TPS6507x MFD driver instead of interacting with the chip directly. The
    > changes are needed before a touch screen driver can be added.
    >
    > The patch set applies cleanly to the MFD repository:
    > git://git.kernel.org/pub/scm/linux/kernel/git/sameo/mfd-2.6.git If the
    > MFD and voltage regulator maintainer would prefer I post patches for a
    > different repository, please let me know.
    All 4 patches applied to my for-next branch.
    Some nit picking advices for your future patches:
    - Include the Signed-off-by and Acked-by you collect along the review cycles.
    - Have shorter patch subject, they typically are less than 80 chars.
    - Describe the changes when moving from patchset vN to patchset vN+1. Also we
    prefer "[PATCH vN]" to "[PATCH]-vN", it makes our life easier when applying
    your patches.

    Thanks a lot for your work.

    Cheers,
    Samuel.

    --
    Intel Open Source Technology Centre
    http://oss.intel.com/


    \
     
     \ /
      Last update: 2010-04-07 10:45    [W:0.021 / U:29.136 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site