lkml.org 
[lkml]   [2010]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] perf: Store active software events in a hashlist
From
Date
On Wed, 2010-04-07 at 13:52 +0200, Frederic Weisbecker wrote:
> On Wed, Apr 07, 2010 at 11:02:26AM +0200, Peter Zijlstra wrote:
> > On Mon, 2010-04-05 at 16:08 +0200, Frederic Weisbecker wrote:
> > > +#define SWEVENT_HLIST_BITS 8
> > > +#define SWEVENT_HLIST_SIZE ((1 << (SWEVENT_HLIST_BITS + 1)) - 1)
> >
> > That seems to result in 9 bits worth, doesn't it?
>
>
> Oh right, I was confused, will zapp the + 1.
>

Also, what you're computing seems to be a mask, not a size

So with BITS = 8, you want
SIZE = 1<<BITS = 256
MASK = SIZE-1 = 255

right?



\
 
 \ /
  Last update: 2010-04-07 13:59    [W:0.060 / U:0.920 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site