lkml.org 
[lkml]   [2010]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3] OMAP: Fix for bus width which improves SD card's peformance.
    On Tue, Apr 06, 2010 at 06:55:03PM +0200, ext Nishanth Menon wrote:
    >some reasons why i love switch statements ;) since I dont expect other
    >than precisely 4 and 8 (do we expect 5,6,7 - i might be wrong).. but if
    >it is so, wont the following be better?
    >
    >switch (mmc_slot(host).wires)
    >{
    >case 8:
    > mmc->caps |= MMC_CAP_8_BIT_DATA;
    > /* fall thru*/
    >case 4:
    > mmc->caps |= MMC_CAP_4_BIT_DATA;
    > break;
    >default:
    > WARN("bad width");
    >}

    I like that, but I remember Madhu (or someone else) saying he thinks
    it's less readable this way. Go figure...

    --
    balbi


    \
     
     \ /
      Last update: 2010-04-06 19:01    [W:3.016 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site