Messages in this thread | | | Date | Mon, 5 Apr 2010 15:04:43 +0100 (BST) | From | James Simmons <> | Subject | Re: [PATCH 23/24] video/matrox: fix dangling pointers |
| |
On Sat, 20 Mar 2010, Wolfram Sang wrote:
> Fix I2C-drivers which missed setting clientdata to NULL before freeing the > structure it points to. Also fix drivers which do this _after_ the structure > was freed already. > > Signed-off-by: Wolfram Sang <w.sang@pengutronix.de> > Cc: Petr Vandrovec <vandrove@vc.cvut.cz> > ---
Acked-by: James Simmons <jsimmons@infradead.org>
> Found using coccinelle, then reviewed. Full patchset is available via > kernel-janitors, linux-i2c, and LKML. > --- > drivers/video/matrox/matroxfb_maven.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/video/matrox/matroxfb_maven.c b/drivers/video/matrox/matroxfb_maven.c > index 91af915..e7b0ec3 100644 > --- a/drivers/video/matrox/matroxfb_maven.c > +++ b/drivers/video/matrox/matroxfb_maven.c > @@ -1254,6 +1254,7 @@ static int maven_probe(struct i2c_client *client, > goto ERROR4; > return 0; > ERROR4:; > + i2c_set_clientdata(client, NULL); > kfree(data); > ERROR0:; > return err; > -- > 1.7.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
| |