Messages in this thread | | | From | Changli Gao <> | Date | Tue, 6 Apr 2010 10:58:28 +0800 | Subject | Re: [PATCH] IPVS: replace sprintf to snprintf to avoid stack buffer overflow |
| |
On Tue, Apr 6, 2010 at 10:50 AM, <wzt.wzt@gmail.com> wrote: > IPVS not check the length of pp->name, use sprintf will cause stack buffer overflow. > struct ip_vs_protocol{} declare name as char *, if register a protocol as: > struct ip_vs_protocol ip_vs_test = { > .name = "aaaaaaaa....128...aaa", > .debug_packet = ip_vs_tcpudp_debug_packet, > }; > > when called ip_vs_tcpudp_debug_packet(), sprintf(buf, "%s TRUNCATED", pp->name); > will cause stack buffer overflow. >
Long messages will be truncated instead of buffer overflow. We need to find a way to handle long messages elegantly.
-- Regards, Changli Gao(xiaosuo@gmail.com) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |