lkml.org 
[lkml]   [2010]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH -mm 2/5] asm-generic: add NEED_SG_DMA_LENGTH to define sg_dma_len()
From
On Tue, 6 Apr 2010 08:46:38 +0900
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> wrote:

> On Mon, 5 Apr 2010 16:35:41 -0700
> Andrew Morton <akpm@linux-foundation.org> wrote:
>
> > On Sun, 4 Apr 2010 23:25:50 +0900
> > FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> wrote:
> >
> > > There are only two ways to define sg_dma_len(); use sg->dma_length or
> > > sg->length. This patch introduces NEED_SG_DMA_LENGTH that enables
> > > architectures to choose sg->dma_length or sg->length.
> >
> > i386 allnoconfig:
> >
> > arch/x86/kernel/pci-nommu.c: In function 'nommu_map_sg':
> > arch/x86/kernel/pci-nommu.c:71: error: 'struct scatterlist' has no member named 'dma_length'
> >
> > So I enabled NEED_SG_DMA_LENGTH on x86_32 as well. It compiles...
>
> Sorry about that. The fix is fine by me. We can remove dma_length in
> pci-nommu.c though (there is no point of setting dma_length here).

Oops, I forgot that pci-nommu.c is also used on x86_64.

There is no point of setting dma_length here on x86_32 but we need to
do on x86_64 since x86_64 uses dma_length. Your fix is correct.

Sorry again.


\
 
 \ /
  Last update: 2010-04-06 02:07    [from the cache]
©2003-2011 Jasper Spaans